fix: fix topology errors in line hit detection & optimizations

[megawac]

This fixes an issue where jsts may throw TopologyError errors when building the intersections due to the snappable lines built having invalid geometry. We also do some minor performance work by

1. Parsing the lines to jsts representations a single time, instead of each call through the loop
2. moving the isSameLine check prior to the IntersectionOp for some minor performance in the case we can avoid the work.

Others

• It's not a hack or at least an unauthorized hack :).
• Everything in ticket description has been fixed.
• The author of the MR has made its own review before assigning the reviewer (made this a month ago and has been thoroughly tested).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
openlayers-editor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 9, 2023 3:26pm

[oterral]

@megawac thx for the PRs and sorry for the late answer. I review all of them and try to be responsive in the next month.

[oterral]

@megawac Have you some more precise info about those topology error ? Could be nice to have an example.

[megawac]

I seem to recall them occurring quite often when #267 was occurring... I'll see if I can track down if there was more context on internal tickets.

[megawac]

This is from the original ticket reported on our side. So in the case the case of the error, parsedLineB snap line appears to be invalid from the error below. There is a video of the error occurring but I'd have to get clearance to share I believe

Uncaught TopologyException: found non-noded intersection between LINESTRING ( 9.952973188580247 2.35845900632583, 11.739231890263671 2.3680559374052663 ) and LINESTRING ( 9.952973188580248 2.35845900632583, 11.452360499376073 508.73944164968873 ) [ (9.952973188580248, 2.35845900632583, NaN) ]
    at g.checkValid (bundle.js)
    at E.checkValid (bundle.js)
    at E.checkValid (bundle.js)
    at A.computeOverlay (bundle.js)
    at A.getResultGeometry (bundle.js)
    at A.overlayOp (bundle.js)
    at E.getResultGeometry (bundle.js)
    at E.overlayOp (bundle.js)
    at A.intersection (bundle.js)
    at bundle.js
    at Array.forEach (<anonymous>)
    at bundle.js
    at Array.forEach (<anonymous>)
    at J (bundle.js)
    at ee.drawSnapLines (bundle.js)
    at ee.onMove (bundle.js)
    at a.handleEvent (bundle.js)
    at le.handleMapBrowserEvent (bundle.js)
    at u.dispatchEvent (bundle.js)
    at u.relayMoveEvent_ (bundle.js)
    at HTMLDivElement.d (bundle.js)

[oterral]

I've added a file for a unit test. Can you add one tests for the topolgy error?

[oterral]

@megawac can you fix the conflict? I will merge this even without test because it's usefull.