Skip to content

Commit

Permalink
Fix failing PickPoint tests for test_reverse_zoom_parameter
Browse files Browse the repository at this point in the history
It worked locally for me, but failed in CI:

________________ PickPointTestCase.test_reverse_zoom_parameter _________________
test/geocoders/nominatim.py:358: in test_reverse_zoom_parameter
    self.assertIn("Tour Eiffel", result_reverse.address)
E   AssertionError: 'Tour Eiffel' not found in 'Champ de Mars, Place Jacques Rueff, Gros-Caillou, 7e, Paris, Île-de-France, France métropolitaine, 75007, France'

So let's try another major tourist attraction.
  • Loading branch information
KostyaEsmukov committed May 9, 2020
1 parent 94ff1a9 commit 0227c2c
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/geocoders/nominatim.py
Original file line number Diff line number Diff line change
Expand Up @@ -342,20 +342,20 @@ def test_namedetails(self):
self.assertNotIn('namedetails', result.raw)

def test_reverse_zoom_parameter(self):
query = "48.8582602, 2.2944990"
query = "40.689253199999996, -74.04454817144321"
result_reverse = self.reverse_run(
{"query": query, "exactly_one": True, "zoom": "10"},
{},
)
self.assertIn("Paris", result_reverse.address)
self.assertNotIn("Tour Eiffel", result_reverse.address)
self.assertIn("New York", result_reverse.address)
self.assertNotIn("Statue of Liberty", result_reverse.address)

result_reverse = self.reverse_run(
{"query": query, "exactly_one": True},
{},
)
self.assertIn("Paris", result_reverse.address)
self.assertIn("Tour Eiffel", result_reverse.address)
self.assertIn("New York", result_reverse.address)
self.assertIn("Statue of Liberty", result_reverse.address)


class NominatimTestCase(BaseNominatimTestCase, GeocoderTestBase):
Expand Down

0 comments on commit 0227c2c

Please sign in to comment.