Use Point or numerical type data to create a tuple for Nominatim view…

…_box (#299)

geopy/geocoders/osm.py

@@ -1,12 +1,14 @@
 """
 OpenStreetMap geocoder, contributed by Alessandro Pasotti of ItOpen.
 """
+from itertools import chain
 
 from geopy.compat import urlencode
 from geopy.exc import GeocoderQueryError
 from geopy.geocoders.base import DEFAULT_SENTINEL, Geocoder
 from geopy.location import Location
 from geopy.util import logger
+from geopy.point import Point
 
 __all__ = ("Nominatim", )
 
@@ -53,6 +55,10 @@ def __init__(
             See :attr:`geopy.geocoders.options.default_format_string`.
 
         :param tuple view_box: Coordinates to restrict search within.
+            Accepts instances of the :class:`geopy.point.Point`
+            ``[Point(22, 180), Point(-22, -180)]``,
+            or iterables of numeric and string types ``[180, 22, -180, -22]``,
+            ``["180", "22", "-180", "-22"]``
 
         :param str country_bias: Bias results to this country.
 
@@ -202,7 +208,11 @@ def geocode(
 
         # `viewbox` apparently replaces `view_box`
         if self.view_box:
-            params['viewbox'] = ','.join(self.view_box)
+            if all(isinstance(point, Point) for point in self.view_box):
+                p1, p2 = self.view_box
+                params['viewbox'] = ','.join(str(p) for p in chain(p1[1::-1], p2[1::-1]))
+            else:
+                params['viewbox'] = ','.join(str(coord) for coord in self.view_box)
 
         if self.country_bias:
             params['countrycodes'] = self.country_bias

test/geocoders/nominatim.py

@@ -15,6 +15,12 @@ class NominatimTestCase(GeocoderTestBase):
     def setUpClass(cls):
         cls.geocoder = Nominatim()
 
+    def tearDown(self):
+        try:
+            del self.geocoder
+        except AttributeError:
+            pass
+
     def test_geocode(self):
         """
         Nominatim.geocode
@@ -207,3 +213,17 @@ def test_missing_reverse_details(self):
             'address',
             res
         )
+
+    def test_view_box(self):
+        self.geocode_run(
+            {"query": "Maple Street"},
+            {"latitude": 36.809551, "longitude": -97.050604},
+        )
+        for view_box in [(-0.11, 52, -0.15, 50),
+                         [Point(52, -0.11), Point(50, -0.15)],
+                         ("-0.11", "52", "-0.15", "50")]:
+            self.geocoder = Nominatim(view_box=view_box)
+            self.geocode_run(
+                {"query": "Maple Street"},
+                {"latitude": 51.5223513, "longitude": -0.1382104}
+            )