Convert What3Words Geocoder to the v2 API. #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove the OneWord functionality that has been deprecated by What3Words.
Closed
|
Note: what3words API v1 will no longer be available after November 30. It would be good to get this merged before then. |
KostyaEsmukov
requested changes
Mar 15, 2018
| verified. | ||
| verified. As of API v2 only 'https' is supported - this parameter | ||
| remains for backwards compatibility (setting to 'http' will stop | ||
| this geocoder working). |
There was a problem hiding this comment.
I suggest to explicitly raise an exception in case http is passed.
if scheme == "http":
raise ConfigurationError("What3Words doesn't support `http` scheme anymore. Please use `https` instead.")
|
|
||
| if resources.get('error') == "11": | ||
| if 'code' in resources['status']: | ||
| raise exc.GeocoderQueryError( |
There was a problem hiding this comment.
Could you please raise GeocoderAuthenticationFailure here when resources['status']['code'] == 401?
And the same for reverse method below.
|
Merged in #303 |
|
Thanks for this! |
|
Yowsah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the OneWord functionality that has been deprecated by
What3Words.