Rename Mapzen to Pelias, add GeocodeEarth #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapzen has been shut down, but the geocoder software has been open-sourced (see https://pelias.io/).
In this PR the Mapzen class has been renamed to Pelias, which initializer accepts
domainas a required first argument, pointing to the custom Pelias instance.Also GeocodeEarth geocoder (which extends Pelias) has been added, which is the hosted Pelias service provided by the Pelias developers themselves (See the comment #258 (comment)).
I've added test-cases for both Pelias and GeocodeEarth, however, in Travis pipelines only GeocodeEarth is tested (which should be enough, considering that GeocodeEarth extends Pelias with a single difference – it has a default
domain).GeocodeEarth has rather low rate limits: there're a lot of skips in the test runs due to HTTP 429 responses. I'm not sure what we can do with that on our side (except switching over to pre-stored/mocked responses, like with vcrpy, as proposed in #203), so I'm going to keep this as-is for now.
Related discussion: #258