-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed MapBox raw #354
Fixed MapBox raw #354
Conversation
Provide detailed Mapbox place API response to use as a Location `raw` attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please add a test for this? Something like that:
geopy/test/geocoders/nominatim.py
Lines 111 to 114 in 02c838d
self.assertEqual( | |
result_geocode.raw['address']['country'], | |
"Deutschland" | |
) |
@inoks would you be able to work on this in the near future? |
Will you create the test or not @inoks ? Otherwise I would like to create it. |
@zeljkobekcic Please do. |
i have created the test and created a PR for @inoks fork. When he merges the PR into his fork then this PR can be merged. |
adding test for the raw attribute fix
@zeljkobekcic Thanks, I just merged! |
The testing fails for Python 3.4 because it can not be installed. Does anybody knows how to fix it? This is an excerpt from the travis ci log
|
@zeljkobekcic I think as those changes are planned for v2, we need to create PR for the |
Given that currently
It looks like an intermittent failure. I've restarted the job, hopefully this will fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging, thank you @inoks @zeljkobekcic! If the tests would fail again I'll fix them in master.
The tests have passed! https://travis-ci.org/geopy/geopy/builds/534160513 I'm planning to cut a new v1 release next week with these MapBox fixes. Let me know if there's any more issues with MapBox which needs to be addressed. |
|
Provide detailed Mapbox place API response to use as a Location
raw
attribute.Closes #353