Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MapBox raw #354

Merged
merged 4 commits into from
May 18, 2019
Merged

Fixed MapBox raw #354

merged 4 commits into from
May 18, 2019

Conversation

slyapustin
Copy link
Contributor

Provide detailed Mapbox place API response to use as a Location raw attribute.

Closes #353

Provide detailed Mapbox place API response to use as a Location `raw` attribute.
Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please add a test for this? Something like that:

self.assertEqual(
result_geocode.raw['address']['country'],
"Deutschland"
)

@KostyaEsmukov
Copy link
Member

@inoks would you be able to work on this in the near future?

@zeljkobekcic
Copy link
Contributor

zeljkobekcic commented May 14, 2019

Will you create the test or not @inoks ? Otherwise I would like to create it.

@slyapustin
Copy link
Contributor Author

@zeljkobekcic Please do.
Thanks!

@zeljkobekcic
Copy link
Contributor

i have created the test and created a PR for @inoks fork. When he merges the PR into his fork then this PR can be merged.

@slyapustin
Copy link
Contributor Author

@zeljkobekcic Thanks, I just merged!

@zeljkobekcic
Copy link
Contributor

The testing fails for Python 3.4 because it can not be installed. Does anybody knows how to fix it?

This is an excerpt from the travis ci log

Downloading archive: https://storage.googleapis.com/travis-ci-language-archives/python/binaries/ubuntu/14.04/x86_64/python-3.4.tar.bz2
127.27s$ curl -sSf -o python-3.4.tar.bz2 ${archive_url}
curl: (7) Failed to connect to storage.googleapis.com port 443: Connection timed out
Unable to download 3.4 archive. The archive may not exist. Please consider a different version.

@slyapustin
Copy link
Contributor Author

@zeljkobekcic I think as those changes are planned for v2, we need to create PR for the 2 branch, where tests are only for Python 3.6 and 3.7.

@KostyaEsmukov
Copy link
Member

I think as those changes are planned for v2, we need to create PR for the 2 branch, where tests are only for Python 3.6 and 3.7.

Given that currently raw might be considered completely broken, I believe it's okay to publish this in v1.

The testing fails for Python 3.4 because it can not be installed. Does anybody knows how to fix it?

It looks like an intermittent failure. I've restarted the job, hopefully this will fix it.

Copy link
Member

@KostyaEsmukov KostyaEsmukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging, thank you @inoks @zeljkobekcic! If the tests would fail again I'll fix them in master.

@KostyaEsmukov KostyaEsmukov merged commit 2adf5e3 into geopy:master May 18, 2019
@KostyaEsmukov
Copy link
Member

The tests have passed! https://travis-ci.org/geopy/geopy/builds/534160513

I'm planning to cut a new v1 release next week with these MapBox fixes. Let me know if there's any more issues with MapBox which needs to be addressed.

@KostyaEsmukov
Copy link
Member

1.20.0 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapbox raw attribute does not contains geocoder response for the place
4 participants