Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Geocoder (fix #210) #315

Open
wants to merge 13 commits into
base: master
from
Open

Configurable Geocoder (fix #210) #315

wants to merge 13 commits into from

Conversation

@borrob
Copy link
Collaborator

borrob commented Jan 31, 2020

An implementation for issue #210: Configurable Geocoder

The plugin system is used to create a configurable geocoder. The geocoder plugin class and specific parameters are specified in the config_main.py or config_site.py. The base setup refers to the ip-api.com that is already used at the moment.

This PR provides three plugins: using a geocode service on the web via a GET request and via a POST request. The third geocoder returns a (configurable) fixed location which might be useful for intranet/on prem installations of GHC.

I did not check compatibility with the other two open PRs, but conflicts (if any) should be minor.

@justb4

This comment has been minimized.

Copy link
Member

justb4 commented Jan 31, 2020

Need some time to dive in. At least the build failure is not from this PR, but a test that Probes the Resource https://demo.pygeoapi.io/master. That Resource has been failing I now see since jan 28, 2020 10:55 GMT. See https://demo.geohealthcheck.org/resource/165
Latest commit of GHC master and thus demo.geohealthcheck.org instance is from dec 2019. Need to investigate. The error signaled is Validate OpenAPI Compliance:HTTP Error 404: Not Found.

Dived into this, was quite a route among various products/components. All described here: geopython/pygeoapi#356 ...also to note @tomkralidis

@justb4

This comment has been minimized.

Copy link
Member

justb4 commented Feb 3, 2020

opengeospatial/wps-rest-binding#63 was cause and fixed so build shoild pass now.

@borrob

This comment has been minimized.

Copy link
Collaborator Author

borrob commented Feb 4, 2020

Great find and I am happy it all works now. All tests pass.

@borrob borrob self-assigned this Feb 4, 2020
@borrob borrob added the enhancement label Feb 4, 2020
@borrob borrob added this to the Version 0.8.0 milestone Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.