Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first docking prototyp #38

Closed
wants to merge 1 commit into from
Closed

Conversation

rduivenvoorde
Copy link

@tomkralidis: with some xml hacking and some code changes, I got the dialog workings as a docking widget.

You can only dock it to the right of the map currently.

Not sure if I find it ok or not... Maybe we should reshuffle bit first, or maybe there is just too much content to show, to make it a dockwidget in one of the borders (would be nice to be able to dock it in centre).

Anyway: plz have a look and let us decide if we want to go like this, or that we should review the full ui first to make it better to put in a dock.

@tomkralidis
Copy link
Member

Nice! +1 to move ahead like this. I think to dock as a toolbar would reduce the functionality.

Comments:

  • needs some code cleanup (we already know that, as this is a poc)
  • we should bring the help button back somewhere?
  • the natural / init state is docked. Can it be undocked/popped up? Then the user can dock where they like (of course settings take over from there)
  • we need to ensure the buttons work again (map extent, set global)

I have the plugin docked below the layer dock and this significantly improves the workflow. Let's push ahead.

@tomkralidis tomkralidis added this to the 0.3.0 milestone Mar 21, 2014
@kalxas
Copy link
Member

kalxas commented Mar 26, 2014

As per the feedback we got from QGIS team, it is preferred to stay to current window style.
I suggest that we keep this modification in the source tree history, under a branch for future reference.

@tomkralidis
Copy link
Member

OK, we can keep this closed PR as reference, which shows the changes.

@rduivenvoorde
Copy link
Author

ok, pushed my branch to this repo:

https://github.com/geopython/MetaSearch/tree/dock

@kalxas
Copy link
Member

kalxas commented Mar 28, 2014

cool, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants