-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OGC WMS 1.3.0 #25
Comments
Hey Tom, I'd love to use your lib. ;) |
hi @keas thanks for the info. No movement on this one yet. Contributions (patches, pull requests) are more than welcome to make this happen. A good start would be to start with what's in |
Hi, is there still interest in adding support for WMS 1.3.0? |
@roomthily I would say yes there is significant interest. Contributions are welcome. |
Cheers. I have a mostly working version, but had a question about the SRS/CRS handling in the current 1.1.1 class (returns one from what could be many?) and working up a few more doctest examples. I'm hoping to have something ready end of the week/early next week. Are there any sort of contribution guidelines? |
Hi, just noting: be aware of the axis order issue (Y,X for some coordinate J út 3. 3. 2015 v 19:45 odesílatel roomthily notifications@github.com
|
@roomthily this is great news! As far as contributing, I would suggest a clean PR against latest master (no merges/rewriting history) with:
Having said this, we really should have contribution guidelines in a |
No worries - the WMS happy path is set up like the WFS/WCS. If you have some good examples of the axis issues, please let me know and Cheers. On Tue, Mar 3, 2015 at 12:13 PM, Tom Kralidis notifications@github.com
|
So my CRS question relates to the BoundingBox element handling in the ContentMetadata. The existing code for WMS 1.1.1 returns the first BoundingBox (etree find) even though it's valid to have multiple BoundingBox element (I don't have a live service example right at hand for this). It's also valid to have multiple elements in the 1.3.0, from the National Atlas (in the airports1m layer):
For backwards compatibility, I can do the same - return the first element - but Im curious if this was an intentional choice? |
@roomthily +1 for backwards compatibility. We could also introduce a |
As noted in #266 -- we get a failure on WMS 1.3 -- of course, the real solution is in the works with 1.3 support, but in the meantime, it would be nice to get a better error i.e. on first access. OWSlib should check the version of the server ,and return a nice useful NotImplementedError or something, rather than a random failure. Maybe I'll try a patch for that as a fisrt step / contribution -- would that belong in wms.py? |
Given that we are so close to landing OGC WMS 1.3 here, IMHO it would be better to put effort into fixing the remaining issues (PR is here: #223) which then provides both 1.1.1 and 1.3.0 support. Having said this you could probably put some detection in https://github.com/geopython/OWSLib/blob/master/owslib/wms.py#L85 which would figure out it's a WMS 1.3. |
Ah, so close but still waiting on me :(? It is possible that I will have For NotImplemented, if it's added for one service + version, it should be roomthily On Tuesday, July 28, 2015, Tom Kralidis notifications@github.com wrote:
|
darn. And yes, a version check would be good everywhere, but you've got to start somewhere! |
I know, the version check would have been very handy for us this spring as Still no promises before October, but I may be able to find some little On Tue, Jul 28, 2015 at 9:43 AM, Chris Barker notifications@github.com
|
Nothing planned at this point. Sent from my iPhone
|
I took a look at wms.py, line 85 -- but I thikn we need to do it before then -- the reader barfs out. But I noticed something -- the user is passing in a version number (Or a default is being used), so the first check should be right there -- if anon-supported version is asked for, then an error should be raised right there. Then, I think in the Reader code, we'll have to do the check early. Not sure if I"ll get any time to look at this more :-( |
Ah, there's two patterns - there's a parent WxS factory/router class that roomthily On Wed, Jul 29, 2015 at 3:45 PM, Chris Barker notifications@github.com
|
With the 1.3 work perhaps version negotiation should go in the factory? Sent from my iPhone
|
So I'm going to put my user hat on for a minute and just ask this - please Part of why I started implementing 1.3.0 was to get as many OGC versions So please consider just taking care of the set in this. roomthily On Wednesday, July 29, 2015, Tom Kralidis notifications@github.com wrote:
|
Any progress on that issue? I am also interested in WMS 1.3.0 support. |
Yeah, sorry, job change. Will need to rebase again but I think it's at tracking down a couple of On Thu, Apr 7, 2016 at 3:43 AM, Julien Enselme notifications@github.com
Soren Scott just a head's up - taking a bit of a sabbatical so if i don't |
Indeed. And while I am all for complete testing, mostly-there with a few untested features would be much better than no support. |
At long last, now implemented in master via #343. Thanks @roomthily! |
Awesome news - -thanks all! |
(carrying on from #25)
This includes support for namespaces WMS Capabilities XML, as well as coordinate order handling, etc.
The text was updated successfully, but these errors were encountered: