Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line 569 in util.py with python 3.6.2 fails #408

Closed
paalped opened this issue Dec 29, 2017 · 2 comments · Fixed by #474
Closed

line 569 in util.py with python 3.6.2 fails #408

paalped opened this issue Dec 29, 2017 · 2 comments · Fixed by #474
Assignees
Milestone

Comments

@paalped
Copy link

paalped commented Dec 29, 2017

I had to modify line 569 in util.py to:
return raw_text.replace(bom, ''.encode('utf-8'))
for this lib to work in 3.6.2

@cehbrecht cehbrecht self-assigned this Apr 25, 2018
@cehbrecht cehbrecht added this to the 0.17.0 milestone Apr 25, 2018
@cehbrecht
Copy link
Contributor

This is function util.strip_bom:

def strip_bom(raw_text):

Add a unit test first.

cehbrecht added a commit to bird-house/OWSLib that referenced this issue May 9, 2018
cehbrecht added a commit that referenced this issue May 9, 2018
@cehbrecht
Copy link
Contributor

@paalped It took me a bit more to fix this for Python 2/3. Please check if it works you.

See:

def strip_bom(raw_text):

And the test:

def test_strip_bom():

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants