Include custom headers in WMS requests #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I recently needed to interact with a WMS service which require
authentication via a `User-agent` header (from France IGN [1]).
When using `WebMapService` you can actually provide custom headers but
they are not used later on when doing the actual HTTP requests:
wms = WebMapService(
'http://example.com/wms',
version='1.3.0',
headers={'User-agent': 'my-app/1.0'}
)
wms.getmap(...) # Fails as not authorized
The `openURL()` helper already supports sending headers if provided, so
it was just a matter of adding the WMS client instance headers (if present) to
this function call.
Includes a small test.
[1] https://geoservices.ign.fr/documentation/donnees-ressources-wms-geoportail.html
|
I get the same failure ( |
10 tasks
amercader
added a commit
to amercader/munibot
that referenced
this pull request
Mar 29, 2021
Don't pass styles by default, pass headers if provided. This requires a patch in OWSLib to work: geopython/OWSLib#763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently needed to interact with a WMS service which require authentication via a
User-agentheader (from France's IGN).When using
WebMapServiceyou can actually provide custom headers but they are not used later on when doing the actual HTTP requests:The
openURL()helper already supports sending headers if provided, so it was just a matter of adding the WMS client instance headers (if present) to this function call.Includes a small test.