Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up code in WFS classes #892

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

clean up code in WFS classes #892

wants to merge 4 commits into from

Conversation

640kb
Copy link
Contributor

@640kb 640kb commented Oct 11, 2023

Code cleaned up and simplified.
The manual call of the init function is not necessary. Until now, the function is called twice.

@640kb
Copy link
Contributor Author

640kb commented Oct 11, 2023

2023-10-11T10:22:58.9093231Z =================================== FAILURES ===================================
2023-10-11T10:22:58.9094249Z �[31m�[1m__________________________ test_ogcapi_records_pycsw ___________________________�[0m
2023-10-11T10:22:58.9094776Z Traceback (most recent call last):
2023-10-11T10:22:58.9110680Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/runner.py", line 341, in from_call
2023-10-11T10:22:58.9111818Z     result: Optional[TResult] = func()
2023-10-11T10:22:58.9112802Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/runner.py", line 262, in <lambda>
2023-10-11T10:22:58.9113553Z     lambda: ihook(item=item, **kwds), when=when, reraise=reraise
2023-10-11T10:22:58.9114337Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_hooks.py", line 493, in __call__
2023-10-11T10:22:58.9114947Z     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
2023-10-11T10:22:58.9115767Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_manager.py", line 115, in _hookexec
2023-10-11T10:22:58.9116391Z     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
2023-10-11T10:22:58.9117190Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_callers.py", line 152, in _multicall
2023-10-11T10:22:58.9117762Z     return outcome.get_result()
2023-10-11T10:22:58.9118488Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_result.py", line 114, in get_result
2023-10-11T10:22:58.9119071Z     raise exc.with_traceback(exc.__traceback__)
2023-10-11T10:22:58.9119823Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_callers.py", line 77, in _multicall
2023-10-11T10:22:58.9121923Z     res = hook_impl.function(*args)
2023-10-11T10:22:58.9122623Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/runner.py", line 177, in pytest_runtest_call
2023-10-11T10:22:58.9123037Z     raise e
2023-10-11T10:22:58.9123714Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/runner.py", line 169, in pytest_runtest_call
2023-10-11T10:22:58.9124136Z     item.runtest()
2023-10-11T10:22:58.9125046Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/python.py", line 1792, in runtest
2023-10-11T10:22:58.9125718Z     self.ihook.pytest_pyfunc_call(pyfuncitem=self)
2023-10-11T10:22:58.9126549Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_hooks.py", line 493, in __call__
2023-10-11T10:22:58.9127066Z     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
2023-10-11T10:22:58.9127772Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_manager.py", line 115, in _hookexec
2023-10-11T10:22:58.9128262Z     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
2023-10-11T10:22:58.9128950Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_callers.py", line 113, in _multicall
2023-10-11T10:22:58.9129484Z     raise exception.with_traceback(exception.__traceback__)
2023-10-11T10:22:58.9130197Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/pluggy/_callers.py", line 77, in _multicall
2023-10-11T10:22:58.9130625Z     res = hook_impl.function(*args)
2023-10-11T10:22:58.9131276Z   File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/_pytest/python.py", line 194, in pytest_pyfunc_call
2023-10-11T10:22:58.9131731Z     result = testfunction(**testargs)
2023-10-11T10:22:58.9132216Z   File "/home/runner/work/OWSLib/OWSLib/tests/test_ogcapi_records_pycsw.py", line 26, in test_ogcapi_records_pycsw
2023-10-11T10:22:58.9132754Z     assert len(conformance['conformsTo']) == 18
2023-10-11T10:22:58.9133070Z AssertionError: assert 14 == 18
2023-10-11T10:22:58.9134810Z  +  where 14 = len(['http://www.opengis.net/spec/ogcapi-common-1/1.0/conf/core', 'http://www.opengis.net/spec/ogcapi-common-2/1.0/conf/collections', 'http://www.opengis.net/spec/ogcapi-features-1/1.0/conf/core', 'http://www.opengis.net/spec/ogcapi-features-3/1.0/conf/queryables', 'http://www.opengis.net/spec/ogcapi-features-3/1.0/conf/queryables-query-parameters', 'http://www.opengis.net/spec/ogcapi-features-3/1.0/conf/filter', ...])
2023-10-11T10:22:58.9136083Z �[33m=============================== warnings summary ===============================�[0m

Is the test test_ogcapi_records_pycsw up to date?

The website https://demo.pycsw.org/cite/conformance has only 14 entries.

@coveralls
Copy link

coveralls commented Oct 12, 2023

Coverage Status

coverage: 58.748% (-0.5%) from 59.265% when pulling 7d41614 on 640kb:master into 59ab2c3 on geopython:master.

@640kb
Copy link
Contributor Author

640kb commented Oct 12, 2023

I have updated the test.

In the commit geopython/pycsw@e1abe9b the number of entries for "conformance" and "queryables" have changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants