Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ISO parsing to support gmd:distributorTransferOptions #238

Closed
tomkralidis opened this issue Apr 16, 2014 · 9 comments
Closed

fix ISO parsing to support gmd:distributorTransferOptions #238

tomkralidis opened this issue Apr 16, 2014 · 9 comments

Comments

@tomkralidis
Copy link
Member

cc @pacioos @rsignell-usgs

ncISO generated metadata stores linkes in gmd:distributorTransferOptions, not gmd:transferOptions. Turns out OWSLib already supports both, so extend pycsw.metadata to additionally scan/store md.distribution.distributor.online links.

@tomkralidis tomkralidis added this to the 1.8.1 milestone Apr 16, 2014
@rsignell-usgs
Copy link

So does this impact our ability to discover service endpoints at data.gov, for datasets where the ISO metadata was was originally generated by ncISO?

@tomkralidis
Copy link
Member Author

In the case where elementsetname != full and outputschema != http://www.isotc211.org/2005/gmd, yes, in a positive way, where there will be more links available.

Having said this.this will not solve the links types issue, which is a whole other issue.

@pacioos
Copy link

pacioos commented Apr 16, 2014

Wanted to point out that ncISO stores one or more links not only in
gmd:distributorTransferOptions, but also in srv:SV_ServiceIdentification.
Both contain critical endpoints.
Thanks,
John

On Wed, Apr 16, 2014 at 7:58 AM, Tom Kralidis notifications@github.comwrote:

In the case where elementsetname != full and outputschema !=
http://www.isotc211.org/2005/gmd, yes, in a positive way, where there
will be more links available.

Having said this.this will not solve the links types issue, which is a
whole other issue.

Reply to this email directly or view it on GitHubhttps://github.com//issues/238#issuecomment-40631078
.

@tomkralidis
Copy link
Member Author

thanks @pacioos. So from srv:SV_ServiceIdentification, I will scan/add all the srv:containsOperations/srv:SV_OperationMetadata/srv:connectPoint/gmd:CI_OnlineResource links. I think that's all of them now?

@pacioos
Copy link

pacioos commented Apr 17, 2014

Correct. Thank you!

On Wed, Apr 16, 2014 at 1:56 PM, Tom Kralidis notifications@github.comwrote:

thanks @pacioos https://github.com/pacioos. So from
srv:SV_ServiceIdentification, I will scan/add all the
srv:containsOperations/srv:SV_OperationMetadata/srv:connectPoint/gmd:CI_OnlineResourcelinks. I think that's all of them now?

Reply to this email directly or view it on GitHubhttps://github.com//issues/238#issuecomment-40666697
.

@tomkralidis
Copy link
Member Author

Fixed in master and 1.8 branch.

@amilan17
Copy link

Please be aware that distribution links in the ISO metadata can be available from two different Xpaths in the distribution section of ISO.

NcISO always outputs the links at this Xpath:
gmd:distributionInfo/gmd:MD_Distribution/gmd:distributor/gmd:MD_Distributor/gmd:distributorTransferOptions/gmd:MD_DigitalTransferOptions/gmd:onLine/gmd:CI_OnlineResource

But you may stumble across ISO records that also have links at this Xpath:
gmd:distributionInfo/gmd:MD_Distribution/gmd:transferOptions/gmd:MD_DigitalTransferOptions/gmd:onLine/gmd:CI_OnlineResource

@tomkralidis
Copy link
Member Author

@amilan17 thanks for the heads up. I think this is covered in https://github.com/tomkralidis/pycsw/blob/master/pycsw/metadata.py#L953-L984

@amilan17
Copy link

Yes it does!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants