RFC8 - Move to pytest testing tool #495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the result of cleaning up the git commit history in the previous pull request. This PR supersedes the previous one, which has been closed.
Overview
This pull request implements the changes proposed in RFC8 - Move to pytest testing tool
The work is not finished yet. I am submitting the PR already in order to have a more public place for early review for the RFC and also to allow testing the incoming changes to travis.
A rough draft of the completed/todo list and current status:
sqlite
databasepostgresql
databasepaverment.py
runtests
test runnerpytest-cov
pluginpytest-timeout
pluginsqlite
as backend andpython2.6
sqlite
as backend andpython2.7
sqlite
as backend andpython3.4
sqlite
as backend andpython3.5
I plan to complete the missing items on the list shortly and then call for a vote on the RFC. Currently I'm facing some troubles with the
harvesting
suite as I'm getting some errors that seem to be external to pycsw. The other suites are all passing.Related Issue / Discussion
RFC8 - Move to pytest testing tool
Issue #428
Additional Information
I'm contemplating other tasks that could be done and that are somehow related to this PR. I've decided to keep them out of scope for this:
pytest-xdist
plugin - May require further changes and I did not feel like delaying this PR even more;postgresql
as backend - There are some tests that are currently not working with postgresql. This has nothing to do with this PR, the tests are broken in the current master as well. We can tackle this more effectively once we get an automated way to run postgresql tests;mysql
database - Requires further development. Since this feature is not present in the current master I guess it is not a priority;Contributions and Licensing
(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)