Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back diff output for functional tests #550

Merged
merged 2 commits into from Nov 9, 2017

Conversation

ricardogsilva
Copy link
Member

Overview

This PR adds a new --functional-prefer-diffs flag to the test runner. It enables comparison of test results with their expected values by using python's difflib.

Related Issue / Discussion

Additional Information

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@codecov
Copy link

codecov bot commented Nov 5, 2017

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #550   +/-   ##
=======================================
  Coverage   55.93%   55.93%           
=======================================
  Files          29       29           
  Lines        6338     6338           
  Branches     1342     1342           
=======================================
  Hits         3545     3545           
- Misses       2412     2413    +1     
+ Partials      381      380    -1
Flag Coverage Δ
#integrationtests 54.57% <ø> (ø) ⬆️
#unittests 7.63% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pycsw/ogc/fes/fes2.py 39.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca558a1...c5eb213. Read the comment docs.

@tomkralidis tomkralidis merged commit 17f8b23 into geopython:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants