Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'async' property to fix SyntaxError with Python 3.7. #571

Merged
merged 1 commit into from
Jul 15, 2018

Conversation

sebastic
Copy link
Contributor

Overview

Rename async property to asynchronous to fix SyntaxError with Python 3.7.

async is now a reserved keyword in Python 3.7.

Related Issue / Discussion

Fixes: #570

Additional Information

Backwards incompatible syntax changes:

https://docs.python.org/3/whatsnew/3.7.html

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@codecov
Copy link

codecov bot commented Jul 15, 2018

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is 16.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files          28       28           
  Lines        6355     6355           
  Branches     1349     1349           
=======================================
  Hits         3547     3547           
- Misses       2422     2423    +1     
+ Partials      386      385    -1
Flag Coverage Δ
#integrationtests 54.46% <16.66%> (ø) ⬆️
#unittests 7.58% <0%> (ø) ⬆️
Impacted Files Coverage Δ
pycsw/ogc/csw/csw3.py 47.5% <0%> (ø) ⬆️
pycsw/ogc/csw/csw2.py 71.73% <0%> (ø) ⬆️
pycsw/server.py 64.35% <25%> (ø) ⬆️
pycsw/ogc/fes/fes2.py 39.13% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 576d4c5...d22f2da. Read the comment docs.

@tomkralidis tomkralidis merged commit d008973 into geopython:master Jul 15, 2018
@sebastic sebastic deleted the python3.7-async branch July 16, 2018 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SyntaxError: invalid syntax due to async being a reserved keyword in Python 3.7
2 participants