Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test invalid gml:posList geometry (#621) #622

Merged
merged 1 commit into from Aug 25, 2020

Conversation

tomkralidis
Copy link
Member

Overview

Adds testing gml:posList length of geometry tuples.

Related Issue / Discussion

Fixes #621

Additional Information

NA

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #622 into master will increase coverage by 0.22%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   56.21%   56.44%   +0.22%     
==========================================
  Files          28       29       +1     
  Lines        6395     6405      +10     
  Branches     1354     1357       +3     
==========================================
+ Hits         3595     3615      +20     
+ Misses       2408     2397      -11     
- Partials      392      393       +1     
Flag Coverage Δ
#integrationtests 55.08% <66.66%> (+0.22%) ⬆️
#unittests 7.52% <8.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pycsw/core/repository.py 62.32% <0.00%> (+0.70%) ⬆️
pycsw/ogc/gml/gml3.py 64.46% <72.72%> (+9.59%) ⬆️
pycsw/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a657e...c49e3d2. Read the comment docs.

@tomkralidis
Copy link
Member Author

@cnavacch works for you? I put a test for at least 4 coordinates given the point codepath doesn't use gml:posList. If this works for you, I'll merge.

pycsw/ogc/gml/gml3.py Outdated Show resolved Hide resolved
pycsw/ogc/gml/gml3.py Outdated Show resolved Hide resolved
@cnavacch
Copy link

@tomkralidis : sorry for the late reply. All tests work fine for me.

@tomkralidis tomkralidis changed the title test invalid gml:posList goemetry (#621) test invalid gml:posList geometry (#621) Aug 25, 2020
Copy link

@cnavacch cnavacch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all these changes!

@tomkralidis tomkralidis merged commit 3c7b434 into geopython:master Aug 25, 2020
@tomkralidis tomkralidis deleted the issue-621 branch August 25, 2020 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order of coordinates in posList
2 participants