Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process execution request parsing not aligned with OGC API - Processes #1285

Open
ricardogsilva opened this issue Jun 23, 2023 · 8 comments
Open
Labels
bug Something isn't working

Comments

@ricardogsilva
Copy link
Member

ricardogsilva commented Jun 23, 2023

Description
When asking for the execution of a process, pygeoapi parses the incoming request and only keeps the inputs property of the request:

data_dict = data.get('inputs', {})

According to OGC API - Processes, an execution request has other relevant properties, such as:

  • outputs - allows the client to request different transmission modes (by value or reference) and also to select between available media-types for each output - as such, only the default transmission mode (by value) and for a single media type per output are supported

  • response - allows the client to either ask for a raw response or a document response. As such, only the default value, wich is raw response, is supported

  • subscriber - allows the client to ask to be notified when processing is over.

In order to be inline with the spec, pygeoapi ought to pass all properties of the execution request down to the process manager and onto processes, and implement these alternative process execution features

@ricardogsilva ricardogsilva added the bug Something isn't working label Jun 23, 2023
@totycro
Copy link
Contributor

totycro commented Jul 3, 2023

We actually need the subscriber property in our company, so I'm going to look into this.

@totycro
Copy link
Contributor

totycro commented Jul 5, 2023

^ this PR is a straightforward implementation of subscriber, we can discuss if anything more advanced/different is needed

@StefanBrand
Copy link

@tomkralidis @ricardogsilva Please, comment on the status of this issue and the related merge request(s). We would like to send Slack messages for finished jobs.

@ricardogsilva
Copy link
Member Author

@StefanBrand

To the best of my knowledge there hasn't been much progress on this.

I've reviewed the proposed PR back in July and I'm +1 for it to be merged (with some smaller tweaks, which have mostly already been addressed).

Personally I'm more interested in having support for outputs, as that would unlock a lot of customization in how processes are run - I'm also waiting on the pending PR to be merged so that I can work on implementation of outputs after it.

There could however be some deeper plan for this, as I am not fully in the loop of all the latest OGC-related developments. So I guess the status of this is that we are waiting on @tomkralidis input.

Copy link

As per RFC4, this Issue has been inactive for 90 days. In order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Mar 10, 2024
@StefanBrand
Copy link

Related PRs #1313 and #1448 were updated 5 days and 34 days ago, respectively.

Copy link

This Issue has been inactive for 90 days. As per RFC4, in order to manage maintenance burden, it will be automatically closed in 7 days.

@github-actions github-actions bot added the stale Issue marked stale by stale-bot label Jun 16, 2024
@StefanBrand
Copy link

Current status if I'm not mistaken:

@github-actions github-actions bot removed the stale Issue marked stale by stale-bot label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants