Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parameter Outputs of OGC API Processes #1599

Closed

Conversation

francescoingv
Copy link
Contributor

Overview

The parameter outputs is passed to the Manager, which in turn pass it to the Processor,
subject to the Processor being declared to support the parameter.

The conditional parameter passing to the Processor grant backward compatibility for already developed Processors.

Related Issue / discussion

Solve #1420,
Subset #1285

Additional information

This PR has a breaking signature in BaseManager.execute_process()
If needed, an additional PR could be made to have backward compatibility:
adding a supports_output property to the Manager and handling it as required (currently not in place as I think it may set a maintenance issue).

The backward compatibility of the Processor is given by a supports_outputs property of the BaseProcessor,
by default set to True.
To check the compatibility, the example processor HelloWorld has supports_outputs=True,
while EchoProcessor follow the old signature.

I think an error 501 should be raised on receiving the parameter outputs, and not having the Processor handling it.

Dependency policy (RFC2)

  • I have ensured that this PR meets RFC2 requirements

Updates to public demo

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@francescoingv
Copy link
Contributor Author

Sorry, I made some errors in the pull request process.
Will close and reopen a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant