Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rangetype and domainset in Coverage providers #809

Closed
MartinPontius opened this issue Nov 9, 2021 · 0 comments · Fixed by #813
Closed

Update rangetype and domainset in Coverage providers #809

MartinPontius opened this issue Nov 9, 2021 · 0 comments · Fixed by #813
Labels
bug Something isn't working OGC API - Coverages OGC API - Coverages
Milestone

Comments

@MartinPontius
Copy link
Contributor

Description
As @jerstlouis has pointed out to me, there are two issues in how pygeoapi defines the rangetype and domainset in API Coverages:

  1. The definition field in rangetype should indicate semantics not encoding datatype (see RangeType / SWE Common Confusion). The encoding information could go into an additional field encodingInfo as proposed here.
  2. The "...Type" suffixes have recently been removed in rangetype and domainset as can be seen in the schema and this commit specifically.

As far as I see the providers rasterio_.py and xarray_.py are affected and possibly some tests.

Steps to Reproduce
Check, e.g., this coverage collection on the demo server:

Expected behavior
The definition field in rangetype contains semantics, not encoding. The encoding is in a new field encodingInfo.
The "...Type" suffixes have been removed.

Screenshots/Tracebacks
If applicable, add screenshots to help explain your problem.

Environment

  • OS:
  • Python version:
  • pygeoapi version:

Additional context
Add any other context about the problem here.

@MartinPontius MartinPontius added the bug Something isn't working label Nov 9, 2021
@tomkralidis tomkralidis added this to the 0.12.0 milestone Nov 10, 2021
tomkralidis added a commit to tomkralidis/pygeoapi that referenced this issue Nov 11, 2021
@tomkralidis tomkralidis added OGC API - Coverages OGC API - Coverages and removed OACov labels Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OGC API - Coverages OGC API - Coverages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants