Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for config file properties to PostgreSQL provider #829

Merged

Conversation

jemrobinson
Copy link
Contributor

Add support for the properties keyword from the config file

Closes #828

@tomkralidis
Copy link
Member

Thanks @jemrobinson, cc'ing additional developers for review/comment. A couple of comments:

  • looks like there are some flake8 errors
  • can we add to the PostgreSQL provider tests? Suggest creating another config fixture with properties set and run tests to confirm it works

@jemrobinson
Copy link
Contributor Author

@tomkralidis thanks for pointing those out. I've fixed the flake8 errors and added a test. Let me know if you'd like me to make any other changes.

@tomkralidis
Copy link
Member

Thanks @jemrobinson ; looks like there are some flake8 failures in tests/test_postgresql_provider.py

@jemrobinson
Copy link
Contributor Author

Sorry! Should be fixed now.

@tomkralidis tomkralidis merged commit 3969fc0 into geopython:master Dec 6, 2021
@tomkralidis
Copy link
Member

Thanks @jemrobinson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support properties config option in PostgreSQL
2 participants