closed ports of elastic docker

[krishnaglodha]

Related Issue / Discussion

PR against issue #1363

Additional Information

Ports are closed now, although I see undefined in the popup , should I create issue and fix this ?

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

• I'd like to contribute Close the elastic ports on the elastic docker example #1363 to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
• I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

[PascalLike]

Thank you Krishna! But for the month of October, it is probably better to leave these hacktoberfest issues for people who are approaching pygeoapi for the first time. These are very suitable activities to get closer to the code base as ice breakers 🙏

[doublebyte1]

Thank you for contributing @krishnaglodha! 👍🏽

It want to address two issues, it would be better to issue two different PR, each one with the code that addresses specifically that issue :-) . You can read more about this in the contribution guidelines.

[doublebyte1]

@krishnaglodha : this is not closing the port. It is assigning the port to a random port in the host.

[doublebyte1]

@krishnaglodha Thank you for this, but this is actually addressing a different issue https://github.com/geopython/pygeoapi/issues/1362 . Please don't address it in this PR.

[krishnaglodha]

Thanks I'll separate PR for both issues

[krishnaglodha]

Thanks I'll separate PR for both issues

[doublebyte1]

@krishnaglodha Please don't do anything else and read the other comments from @PascalLike and myself.

[krishnaglodha]

Yes will not work on it

[doublebyte1]

Thank you Krishna! But for the month of October, it is probably better to leave these hacktoberfest issues for people who are approaching pygeoapi for the first time. These are very suitable activities to get closer to the code base as ice breakers 🙏

@krishnaglodha I agree :-) If you want to help during the #hacktoberfest, you could create issues, similar to the ones I did: very simple and self contained, for instance fixing a bug on the documentation, or something in the configuration. That would be really helpful! 🥇