indicate which attribute to use as label for an item #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for optimizing #133, it also brings in an aspect of #100. I wanted to combine the two to see the full benefit of it. In config you can assign one attribute as being the label/name/title of the item.
This value is then used as label on the map and title of the item page
I also introduced the capability to set this value in a multilingual way
In case you ask the french representation of the page, the french attribute will be used as label
This required a language to be taken from accept-language or url-override, which had quite impact on the code, i can image people may want to refactor that aspect, please make suggestions
I considered also an approach in which i would add this aspect as part of the context, maybe @alpha-beta-soup can provide some suggestion there, maybe both approaches can co-exist?