add translation system to pygeoapi #725

pvgenuchten · 2021-07-10T23:06:19Z

this pr adds a translation system to pygeoapi, see locale/readme.md on how to set up

extract latest keys in .pot file with: pybabel extract -F babel-mapping.ini -o locale/messages.pot ./
then update .po language file: pybabel update -d locale -l fr -i locale/messages.pot
update translations and compile .mo file: pybabel compile -d locale -l fr

Run pygeoapi and switch language to french ?lang=fr, notice some hardcoded strings translated.

GeoSander

Good start @pvgenuchten and happy to see that it was easy to put the translations in place!
For the links sections (as generated by api.py) we should have a look how to properly build in the Babel/gettext stuff there, but it might be better to do this after the API refactor, don't you agree @tomkralidis?

GeoSander · 2021-07-12T08:13:37Z

pygeoapi/util.py

+    translations = Translations.load('locale', [locale_])
+    env.install_gettext_translations(translations)


We might need to check how efficient this is (loading all translations each time when render_j2_template is called). If the locale has not changed, there's no need to reload all translations. But perhaps Babel and/or install_gettext_translations already has such a mechanism in place.

Good start @pvgenuchten and happy to see that it was easy to put the translations in place!
For the links sections (as generated by api.py) we should have a look how to properly build in the Babel/gettext stuff there, but it might be better to do this after the API refactor, don't you agree @tomkralidis?

+1

GeoSander · 2021-07-12T08:15:38Z

pygeoapi/util.py

@@ -44,7 +44,8 @@

 import dateutil.parser
 # from babel.support import Translations


Please remove this line :)

alexandreleroux · 2021-07-12T11:46:05Z

locale/fr/LC_MESSAGES/messages.po

+
+#: pygeoapi/templates/landing_page.html:35
+msgid "License"
+msgstr "License"


License in French is spelled Licence, thanks

tomkralidis

Great work here @pvgenuchten ! Minor comments. I would also add a sentence or two in https://docs.pygeoapi.io/en/latest/language.html

tomkralidis · 2021-07-14T01:26:39Z

locale/readme.md

@@ -0,0 +1,32 @@
+# Howto set up language files


Rename file to locale/README.md

GeoSander · 2021-07-27T09:38:08Z

@tomkralidis is it okay to merge this (after rebase)?

tomkralidis · 2021-08-03T20:28:04Z

@GeoSander +1, let me know when rebased.

pvgenuchten · 2021-08-22T20:31:08Z

just did a rebase

commit 70edc3c Author: Tom Kralidis <tomkralidis@gmail.com> Date: Thu Aug 26 16:30:46 2021 -0400 update TinyDB q= support for multiple terms (geopython#765) commit 1ff9dfa Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 08:24:28 2021 -0400 update id field passing to HTML template (geopython#764) commit 6fb64e6 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 07:22:53 2021 -0400 fix JSON filter in HTML items/item templates (geopython#761) (geopython#763) commit 6dcd10b Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 06:34:39 2021 -0400 test for item prev and next links on item queries (geopython#752) (geopython#757) commit 7192012 Author: Alexandre Leroux <alexandreleroux@gmail.com> Date: Tue Aug 24 06:37:03 2021 -0400 updates to French translation (geopython#759) commit 995ab2f Author: paul van genuchten <paul.vangenuchten@geocat.net> Date: Mon Aug 23 02:42:10 2021 +0200 add translation system to pygeoapi (geopython#725) * adds translation keys to templates * adds translation keys to templates * suggestions from github pr 2 commit bc97ed4 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Sun Aug 22 08:28:56 2021 -0400 add geometry to queryables (geopython#755) commit 9d92090 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 18 15:28:55 2021 -0400 update OAProc execute handling (geopython#754) * fix OAProc default output to raw * control outputs list from api machinery * fix tests

commit 774ff49 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Sep 1 09:02:28 2021 -0400 update translations (geopython#760) (geopython#762) * update translations (geopython#760) * fix syntax * update translations * update docs * fix typos commit cf9bd22 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Tue Aug 31 10:11:31 2021 -0400 Update plugins.rst (geopython#770) commit 70edc3c Author: Tom Kralidis <tomkralidis@gmail.com> Date: Thu Aug 26 16:30:46 2021 -0400 update TinyDB q= support for multiple terms (geopython#765) commit 1ff9dfa Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 08:24:28 2021 -0400 update id field passing to HTML template (geopython#764) commit 6fb64e6 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 07:22:53 2021 -0400 fix JSON filter in HTML items/item templates (geopython#761) (geopython#763) commit 6dcd10b Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 06:34:39 2021 -0400 test for item prev and next links on item queries (geopython#752) (geopython#757) commit 7192012 Author: Alexandre Leroux <alexandreleroux@gmail.com> Date: Tue Aug 24 06:37:03 2021 -0400 updates to French translation (geopython#759) commit 995ab2f Author: paul van genuchten <paul.vangenuchten@geocat.net> Date: Mon Aug 23 02:42:10 2021 +0200 add translation system to pygeoapi (geopython#725) * adds translation keys to templates * adds translation keys to templates * suggestions from github pr 2 commit bc97ed4 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Sun Aug 22 08:28:56 2021 -0400 add geometry to queryables (geopython#755) commit 9d92090 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 18 15:28:55 2021 -0400 update OAProc execute handling (geopython#754) * fix OAProc default output to raw * control outputs list from api machinery * fix tests

* Update plugin.py for SPARQL * Create sparql.py * Update requirements-provider.txt * Add files via upload * Update requirements-provider.txt * Update api.py * Update plugin.py * Update plugin.py * Update plugin.py * Squashed commit of the following: commit 70edc3c Author: Tom Kralidis <tomkralidis@gmail.com> Date: Thu Aug 26 16:30:46 2021 -0400 update TinyDB q= support for multiple terms (geopython#765) commit 1ff9dfa Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 08:24:28 2021 -0400 update id field passing to HTML template (geopython#764) commit 6fb64e6 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 07:22:53 2021 -0400 fix JSON filter in HTML items/item templates (geopython#761) (geopython#763) commit 6dcd10b Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 06:34:39 2021 -0400 test for item prev and next links on item queries (geopython#752) (geopython#757) commit 7192012 Author: Alexandre Leroux <alexandreleroux@gmail.com> Date: Tue Aug 24 06:37:03 2021 -0400 updates to French translation (geopython#759) commit 995ab2f Author: paul van genuchten <paul.vangenuchten@geocat.net> Date: Mon Aug 23 02:42:10 2021 +0200 add translation system to pygeoapi (geopython#725) * adds translation keys to templates * adds translation keys to templates * suggestions from github pr 2 commit bc97ed4 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Sun Aug 22 08:28:56 2021 -0400 add geometry to queryables (geopython#755) commit 9d92090 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 18 15:28:55 2021 -0400 update OAProc execute handling (geopython#754) * fix OAProc default output to raw * control outputs list from api machinery * fix tests * Squashed commit of the following: commit 774ff49 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Sep 1 09:02:28 2021 -0400 update translations (geopython#760) (geopython#762) * update translations (geopython#760) * fix syntax * update translations * update docs * fix typos commit cf9bd22 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Tue Aug 31 10:11:31 2021 -0400 Update plugins.rst (geopython#770) commit 70edc3c Author: Tom Kralidis <tomkralidis@gmail.com> Date: Thu Aug 26 16:30:46 2021 -0400 update TinyDB q= support for multiple terms (geopython#765) commit 1ff9dfa Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 08:24:28 2021 -0400 update id field passing to HTML template (geopython#764) commit 6fb64e6 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 07:22:53 2021 -0400 fix JSON filter in HTML items/item templates (geopython#761) (geopython#763) commit 6dcd10b Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 25 06:34:39 2021 -0400 test for item prev and next links on item queries (geopython#752) (geopython#757) commit 7192012 Author: Alexandre Leroux <alexandreleroux@gmail.com> Date: Tue Aug 24 06:37:03 2021 -0400 updates to French translation (geopython#759) commit 995ab2f Author: paul van genuchten <paul.vangenuchten@geocat.net> Date: Mon Aug 23 02:42:10 2021 +0200 add translation system to pygeoapi (geopython#725) * adds translation keys to templates * adds translation keys to templates * suggestions from github pr 2 commit bc97ed4 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Sun Aug 22 08:28:56 2021 -0400 add geometry to queryables (geopython#755) commit 9d92090 Author: Tom Kralidis <tomkralidis@gmail.com> Date: Wed Aug 18 15:28:55 2021 -0400 update OAProc execute handling (geopython#754) * fix OAProc default output to raw * control outputs list from api machinery * fix tests * Prepare for merge into internetofwater/pygeoapi

pvgenuchten requested review from tomkralidis and GeoSander July 10, 2021 23:06

pvgenuchten force-pushed the trans-tpl branch 2 times, most recently from edcf472 to 55d31d4 Compare July 10, 2021 23:34

GeoSander approved these changes Jul 12, 2021

View reviewed changes

alexandreleroux reviewed Jul 12, 2021

View reviewed changes

tomkralidis requested changes Jul 14, 2021

View reviewed changes

locale/readme.md Outdated

@@ -0,0 +1,32 @@

# Howto set up language files

Copy link

Member

tomkralidis Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename file to locale/README.md

pvgenuchten mentioned this pull request Jul 21, 2021

What is everybody going to be working on? opengeospatial/ogcapi-code-sprint-2021-07#1

Closed

pvgenuchten force-pushed the trans-tpl branch 2 times, most recently from e17a13f to fdf9cd3 Compare July 22, 2021 06:40

tomkralidis approved these changes Jul 24, 2021

View reviewed changes

tomkralidis mentioned this pull request Aug 9, 2021

add multilingual capability #100

Closed

Paul added 4 commits August 22, 2021 22:26

adds translation keys to templates

8e0cb95

adds translation keys to templates

7e9b653

suggestions from github pr

96d3f29

suggestions from github pr 2

6da0ec3

pvgenuchten force-pushed the trans-tpl branch from fdf9cd3 to 6da0ec3 Compare August 22, 2021 20:29

tomkralidis merged commit 995ab2f into geopython:master Aug 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add translation system to pygeoapi #725

add translation system to pygeoapi #725

pvgenuchten commented Jul 10, 2021 •

edited

GeoSander left a comment

GeoSander Jul 12, 2021 •

edited

tomkralidis Jul 14, 2021

GeoSander Jul 12, 2021

alexandreleroux Jul 12, 2021

tomkralidis left a comment

tomkralidis Jul 14, 2021

GeoSander commented Jul 27, 2021

tomkralidis commented Aug 3, 2021

pvgenuchten commented Aug 22, 2021

		translations = Translations.load('locale', [locale_])
		env.install_gettext_translations(translations)

		@@ -44,7 +44,8 @@

		import dateutil.parser
		# from babel.support import Translations

add translation system to pygeoapi #725

add translation system to pygeoapi #725

Conversation

pvgenuchten commented Jul 10, 2021 • edited

GeoSander left a comment

Choose a reason for hiding this comment

GeoSander Jul 12, 2021 • edited

Choose a reason for hiding this comment

tomkralidis Jul 14, 2021

Choose a reason for hiding this comment

GeoSander Jul 12, 2021

Choose a reason for hiding this comment

alexandreleroux Jul 12, 2021

Choose a reason for hiding this comment

tomkralidis left a comment

Choose a reason for hiding this comment

tomkralidis Jul 14, 2021

Choose a reason for hiding this comment

GeoSander commented Jul 27, 2021

tomkralidis commented Aug 3, 2021

pvgenuchten commented Aug 22, 2021

pvgenuchten commented Jul 10, 2021 •

edited

GeoSander Jul 12, 2021 •

edited