Upgrade the docker example to ES=8 #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode (so we don't break the python client)
doublebyte1
commented
Sep 16, 2022
| @@ -62,6 +62,10 @@ services: | |||
| ports: | |||
| - 9300:9300 | |||
| - 9200:9200 | |||
| environment: | |||
| ELASTIC_CLIENT_APIVERSIONING: 1 | |||
There was a problem hiding this comment.
running ES 8 in compatibility mode
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
ES8 introduces new capabilities (like the ability to publish data as vector tiles), but we are tied to the elastic-search client, which did not produce a version compatible with 8, yet. See: elastic/elasticsearch-dsl-py#1569
The approach here is to run ES8 in compatibility mode, so that it does not break the client.
Related Issue / Discussion
#970
Contributions and Licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)