Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update $date$ in core.py #81

Closed
RousseauLambertLP opened this issue Nov 21, 2017 · 3 comments
Closed

Update $date$ in core.py #81

RousseauLambertLP opened this issue Nov 21, 2017 · 3 comments

Comments

@RousseauLambertLP
Copy link
Contributor

So $date$ in pygeometa creates a datetime representation. ECDC would like us to change our date format for publication:

  • "Publication date uses gco:DateTime, if the metadata is edited the value is lost as in ECCC metadata editor only is managing gco:Date. For FGP version this was updated, but was requested to not include in ECCC version. Please if you can create the metadata for now using gco:Date "

Should we update pygeometa’s magic $date$ as follows? :

  • $date$ is a magic keyword for YYYY-MM-DD
  • $datetime$$ is a magic keyword for YYYY-MM-DDTHH:MM:SSZ
@tomkralidis
Copy link
Member

Thanks @RousseauLambertLP. Fixed in master. Can you validate and close if the fix works?

@RousseauLambertLP
Copy link
Contributor Author

https://github.com/geopython/pygeometa/blob/master/pygeometa/core.py#L126-129

Shouldn't it be the opposite?

  • $date$ is a magic keyword for YYYY-MM-DD
  • $datetime$$ is a magic keyword for YYYY-MM-DDTHH:MM:SSZ

RousseauLambertLP pushed a commit to RousseauLambertLP/pygeometa that referenced this issue Nov 21, 2017
tomkralidis added a commit to tomkralidis/pygeometa that referenced this issue Nov 21, 2017
@tomkralidis
Copy link
Member

Oops! Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants