Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default output url #219

Merged
merged 2 commits into from Dec 23, 2016
Merged

Conversation

cehbrecht
Copy link
Collaborator

Overview

the default settings for outputurl would result in a broken url builded with urljoin in the storage module. This is fixed with this pull request.

Before:

urljoin('file:////tmp/T', 'output.txt') -> file://tmp/output.txt

Now:

urljoin('file:///tmp/T/', 'output.txt') -> file:///tmp/T/output.txt

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • [x ] I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 76.319% when pulling 990baa6 on bird-house:fix-default-output-url into 286296b on geopython:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 76.319% when pulling 990baa6 on bird-house:fix-default-output-url into 286296b on geopython:master.

@jachym jachym merged commit 7e7e12e into geopython:master Dec 23, 2016
@jachym
Copy link
Member

jachym commented Dec 23, 2016

Thanks @cehbrecht, as always

@jachym jachym added the bug label Dec 23, 2016
@jachym jachym added this to the 4.2.0 milestone Dec 23, 2016
@jachym jachym self-requested a review December 23, 2016 10:48
@jachym jachym self-assigned this Dec 23, 2016
@cehbrecht cehbrecht deleted the fix-default-output-url branch December 23, 2016 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants