Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of mutable as default value in Process.__init__ #660

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

gschwind
Copy link
Collaborator

Using mutable value as default value for input variable of function
create complex bug because those value will be shared by all Process
instance. Thus remove it and replace it by the safe code.

Overview

Related Issue / Discussion

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

Using mutable value as default value for input variable of function
create complex bug because those value will be shared by all Process
instance. Thus remove it and replace it by the safe code.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.378% when pulling 42dfd67 on gschwind:fix-process-init into 7839f52 on geopython:main.

@cehbrecht cehbrecht self-requested a review September 5, 2022 13:54
@cehbrecht cehbrecht merged commit 5f84f5b into geopython:main Sep 5, 2022
@gschwind gschwind deleted the fix-process-init branch September 14, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants