Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate async test #664

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Activate async test #664

merged 3 commits into from
Jan 27, 2023

Conversation

huard
Copy link
Collaborator

@huard huard commented Sep 19, 2022

Overview

A unit test for asynchronous processes was not actually running asynchronously. The test now runs in async mode and will raise an error if it ever runs synchronously.

Related Issue / Discussion

In response to comments in #657

Additional Information

Depends on #663

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

coveralls commented Sep 19, 2022

Coverage Status

Coverage increased (+0.3%) to 81.398% when pulling 06eee7d on huard:activate_async_test into 85ca819 on geopython:main.

Copy link
Collaborator

@gschwind gschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

Thank for the fix :)

The while loop is too simple, It need to handle a time out to avoid infinite waiting, and it also need check for Failed status.

Otherwise pytest is working, when test do not fail :)

Best regards.

@huard
Copy link
Collaborator Author

huard commented Oct 19, 2022

Done

@huard huard requested a review from cehbrecht October 19, 2022 17:46
Copy link
Collaborator

@gschwind gschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me

Maybe you should capitalise commit messages :)

Best regards

@cehbrecht cehbrecht merged commit e41b063 into geopython:main Jan 27, 2023
@cehbrecht
Copy link
Collaborator

@huard thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants