Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the implementation of pywps.inout.literaltypes #668

Merged

Conversation

gschwind
Copy link
Collaborator

@gschwind gschwind commented Nov 9, 2022

Overview

I used function decoration to improve the pywps.inout.literaltypes. This make the code quite nicer to read and avoid mistake when mapping types and their corresponding converter.

Related Issue / Discussion

Additional Information

This contribution is supported by MINES ParisTech.

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

coveralls commented Nov 9, 2022

Coverage Status

Coverage: 81.381% (-0.02%) from 81.398% when pulling d4ee662 on gschwind:improve-literaltype-implementation into 6fa8a21 on geopython:main.

@gschwind gschwind force-pushed the improve-literaltype-implementation branch from 35b7573 to 877ac83 Compare November 9, 2022 17:00
@gschwind
Copy link
Collaborator Author

Hello,

I do not understand the issue with the doc, do someone can help ?

Best regards

@cehbrecht
Copy link
Collaborator

@gschwind looks like tests are failing due to pep8 issues.

Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like this ! Would a function decorator be simpler here instead of a class ?

@huard
Copy link
Collaborator

huard commented Jan 27, 2023

Run flake8 pywps/inout/literaltypes.py. There is some extra spaces on line 30.

@gschwind gschwind force-pushed the improve-literaltype-implementation branch 2 times, most recently from 20fa3ae to bee702b Compare February 7, 2023 09:05
@gschwind gschwind force-pushed the improve-literaltype-implementation branch from bee702b to d4ee662 Compare February 7, 2023 09:24
@cehbrecht cehbrecht merged commit d0bb978 into geopython:main Feb 7, 2023
@cehbrecht
Copy link
Collaborator

@gschwind thanks :) Improvements (@huard) could be added with another PR.

@gschwind gschwind deleted the improve-literaltype-implementation branch September 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants