Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python3.10/3.11, documentation fixes, and general codebase cleanup #677

Merged
merged 15 commits into from
Jul 7, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jul 5, 2023

Overview

This PR does a bit of cleaning in the code base:

  • Many unused imports have been removed.
  • Many Markdown and reST formatting issues (outside the docs) have been corrected.
  • Some docstrings for functions have been cleaned up for typos and better rendering in the documentation.
  • Some URL targets that pointed to insecure addresses (http://) have been promoted to secured ones (https://).
  • References to the master branch have been changed to main.
  • Updated Installation instructions to reflect modern approaches.
  • Added builds on GitHub CI for Python3.10 and Python3.11.
  • Resolved a DeprecationWarning emitted by sqlalchemy (backwards-compatible).
  • Ran isort over the code base to organize imports.

Related Issue / Discussion

Closes #673
Closes #637
Closes #590

Addresses some comments in the following issues:
#669
#336

Additional Information

Contribution Agreement

(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to PyWPS. I confirm that my contributions to PyWPS will be compatible with the PyWPS license guidelines at the time of contribution.
  • I have already previously agreed to the PyWPS Contributions and Licensing Guidelines

@coveralls
Copy link

coveralls commented Jul 5, 2023

Coverage Status

coverage: 81.332% (-0.02%) from 81.35% when pulling a6ebbea on Zeitsperre:housekeeping into c56aba6 on geopython:main.

Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Nice clean-up.

@Zeitsperre
Copy link
Collaborator Author

I'm happy with this for now. There are more than a few modules that looks to be obsolete, so I'll stop here.

@cehbrecht I'll leave the final review, merge, and release to you.

If you'd like me to add more to the CI/pre-commit side of things, let me know and I'll open another PR for those.

@cehbrecht
Copy link
Collaborator

@Zeitsperre looks all good 👍 Thanks for the clean-up 🙂

@cehbrecht
Copy link
Collaborator

If you'd like me to add more to the CI/pre-commit side of things, let me know and I'll open another PR for those.

@Zeitsperre sounds good to add the CI/pre-commit things 👍

@cehbrecht cehbrecht merged commit 58970c9 into geopython:main Jul 7, 2023
7 checks passed
@Zeitsperre Zeitsperre deleted the housekeeping branch July 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update installation docs Back to master/main ... but how?
4 participants