Sanitize tests suite #684
Merged
Sanitize tests suite #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database may change, in particular during tests, thus track change and update database connection accordingly.
The patch also ensure that path of sources does not bleed into the test environnement, as standard practice. It's include pytest.ini.
The TestBase ensure that configuration is properly reset each time a test function is called. It also create a temporary directory where all data for test will be store. All test use that temporary directory, instead of shared '/tmp'
The previous code expect USER environment variable, but in good test environment this requirement is not met.
cehbrecht
approved these changes
Oct 30, 2023
|
py37 will be skipped in future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The patch suite sanitize tests by ensuring that all test run in his own temporary directory and use his own configuration. Moreover each test use their own sqlite database and do not use anymore the memory database. All test should run without side effect on other tests. The patch also ensure that no test file leak and cleanup created files during the tests (check /tmp after run tests before/after the patch suite). It is also setup pytest to run in importlib mode as advised by pytest web page and remove source file from the tests path to ensure that only pip installed files are tested.
The patch suite include #680 , #681 and #682 to work properly.
It's also fix some tests
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)