Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proplem when no Author #3

Closed
ghost opened this issue Oct 12, 2011 · 1 comment
Closed

Proplem when no Author #3

ghost opened this issue Oct 12, 2011 · 1 comment

Comments

@ghost
Copy link

ghost commented Oct 12, 2011

I notice that if the author is empty, when getting Notes the gem cannot retrieve author but also Title.

Here a sample of MyClippings.txt

The Danger of += in JavaScript

  • Note Loc. 1 | Added on Monday, August 29, 2011, 08:47 AM

i need to see the code (not available offline)

Static Code Analysis and Code Contracts

  • Note Loc. 1 | Added on Monday, August 29, 2011, 09:06 AM

maybe a good alternative to resharper...

To fix this I edit the parser around line 40
before it was:

title, author = *first_line

and new way:

if first_line.nil?
title = lines[0]
author = ""
else
title, author = *first_line
end

I know that is not pretty but it works....

@georgboe
Copy link
Owner

Thank you very much for your contribution!
Your change have been added and v1.2.3 is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant