-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle Node versioning? #14
Comments
Being on the bleeding edge of new language features will allow for more unique solutions, so it would be great if it could be kept up to date. Dealing with managing node versions in order to run the tests sounds like a pain, though. Since none of the solutions have been broken by a new version of node yet, I don't see why running CI tests on the latest version of node for the time being would be a problem. Cross that bridge if/when you get there? 😄 |
I agree bleeding edge features expand the possibilities. The challenge here is that one of them only passes in Node 11.4.0 right now... and it’s one I contributed! I know why, but I’m sort of at a loss as to how to refactor it, mostly because it’s obnoxiously obfuscated and the only way I can think to fix it would give away some of the fun :) |
It’s 023, just FYI. |
Closing because #25 is more direct and actionable. |
One of the solutions works in v11.4.0 but not other versions of Node. I blame my own lack of diligence.
Still, it raises an interesting question. I've got a GitHub action running the tests now. Should I pick a version of Node that all the solutions have to work under and stick with that? Should I explore a fancier fix where each solution can post something like it's own
.nvmrc
file and modify the tests to use the requests version of Node?Decisions decisions...
The text was updated successfully, but these errors were encountered: