fix(yaxis): Fixed + unfixed bounds on the same yaxis is now working

georgepauna · May 25, 2021 · f7e4668 · f7e4668
1 parent 76e5ba6
commit f7e4668
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/.devcontainer/ui-lovelace.yaml b/.devcontainer/ui-lovelace.yaml
@@ -1016,3 +1016,19 @@ views:
                 show: true
                 apex_config:
                   tickAmount: 4
+          - type: custom:apexcharts-card
+            header:
+              show: true
+              title: Soft Bounds + fixed bound
+            graph_span: 20min
+            all_series_config:
+              stroke_width: 2
+            series:
+              - entity: sensor.random0_100
+                yaxis_id: first
+            yaxis:
+              - id: first
+                min: 0
+                max: ~80
+                apex_config:
+                  tickAmount: 4
diff --git a/src/apexcharts-card.ts b/src/apexcharts-card.ts
@@ -480,6 +480,7 @@ class ChartsCard extends LitElement {
       if (config.yaxis![idx].apex_config) {
         // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         yAxisDup = mergeDeep(JSON.parse(JSON.stringify(config.yaxis![idx])), config.yaxis![idx].apex_config);
+        delete yAxisDup.apex_config;
       }
       if (typeof yAxisDup.min !== 'number') delete yAxisDup.min;
       if (typeof yAxisDup.max !== 'number') delete yAxisDup.max;
@@ -991,7 +992,7 @@ class ChartsCard extends LitElement {
           }
         });
         yaxis.series_id?.forEach((id) => {
-          if (min !== null) {
+          if (min !== null && yaxis.min_type !== minmax_type.FIXED) {
             // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             this._config!.apex_config!.yaxis![id].min = this._getMinMaxBasedOnType(
               true,
@@ -1001,7 +1002,7 @@ class ChartsCard extends LitElement {
               yaxis.min_type!,
             );
           }
-          if (max !== null) {
+          if (max !== null && yaxis.max_type !== minmax_type.FIXED) {
             // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
             this._config!.apex_config!.yaxis![id].max = this._getMinMaxBasedOnType(
               false,