Removes a debug, fixes a bug when a status fails to be created

georgerogers42 · Aug 15, 2013 · 2fdec2b · 2fdec2b
1 parent 13a2183
commit 2fdec2b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/app/controllers/admin/statuses_controller.rb b/app/controllers/admin/statuses_controller.rb
@@ -49,8 +49,13 @@ def new_or_edit
       end
 
       if @status.save
-        @status.send_to_twitter(current_user) if params[:status][:push_to_twitter] and @status.twitter_id.nil? or @status.twitter_id.empty?
         flash[:notice] = _("Status was successfully %s.", message)
+        if params[:status][:push_to_twitter] and @status.twitter_id.nil? or @status.twitter_id.empty?
+          unless  @status.send_to_twitter(current_user)
+            flash[:error] = _("Oooops something wrong happened")
+            flash[:notice] = nil
+          end
+        end
         redirect_to :action => 'new'
       end
       return

diff --git a/app/models/status.rb b/app/models/status.rb
@@ -64,16 +64,15 @@ def send_to_twitter(user)
       message = "#{message}#{short_permalink}"
     end
 
-    puts message
-
     begin
       tweet = twitter.update(message)
       self.twitter_id = tweet.attrs[:id_str]
       self.save
 
       user.update_twitter_profile_image(tweet.attrs[:user][:profile_image_url])
+      return true
     rescue
-      flash[:error] = "Oooops something wrong happened"
+      return false
     end
   end