Fixed bug in backward() and forward() #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forward() and backward() now have a data argument and the data has to be passed on. This avoids scoping problems and fixes the bug
In backward()/forward() the user now gets an error if they use factor variables for selection.
The documentation now includes a paragraph about factors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Theresa made me aware of a bug in
backward.logistf()andforward.logistf(). When used inside a function, they do not find the data.frame they need to update the model. I added a data argument, so the user now needs to pass the data.frame tobackward.logistf()andforward.logistf(). This solves the issue and avoids any scoping problems.I also added an error message when selecting among factor variables, as this can lead to unexpected behavior.