feat: func metadata support float/bool

georgia-tech-db · Oct 17, 2023 · 7c8b6da · 7c8b6da
1 parent 61af3ed
commit 7c8b6da
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/evadb/catalog/models/function_metadata_catalog.py b/evadb/catalog/models/function_metadata_catalog.py
@@ -17,7 +17,7 @@
 from sqlalchemy.orm import relationship
 
 from evadb.catalog.models.base_model import BaseModel
-from evadb.catalog.models.utils import FunctionMetadataCatalogEntry
+from evadb.catalog.models.utils import FunctionMetadataCatalogEntry, TextPickleType
 
 
 class FunctionMetadataCatalog(BaseModel):
@@ -34,7 +34,7 @@ class FunctionMetadataCatalog(BaseModel):
     __tablename__ = "function_metadata_catalog"
 
     _key = Column("key", String(100))
-    _value = Column("value", String(100))
+    _value = Column("value", TextPickleType())
     _function_id = Column(
         "function_id", Integer, ForeignKey("function_catalog._row_id")
     )

diff --git a/evadb/parser/evadb.lark b/evadb/parser/evadb.lark
@@ -51,7 +51,7 @@ function_metadata: function_metadata_key function_metadata_value
 
 function_metadata_key: uid
 
-function_metadata_value: string_literal | decimal_literal
+function_metadata_value: constant
 
 vector_store_type: USING (FAISS | QDRANT | PINECONE | PGVECTOR | CHROMADB)
 

diff --git a/evadb/parser/lark_visitor/_expressions.py b/evadb/parser/lark_visitor/_expressions.py
@@ -41,6 +41,12 @@ def array_literal(self, tree):
         res = ConstantValueExpression(np.array(array_elements), ColumnType.NDARRAY)
         return res
 
+    def boolean_literal(self, tree):
+        text = tree.children[0]
+        if text == "TRUE":
+            return ConstantValueExpression(True, ColumnType.BOOLEAN)
+        return ConstantValueExpression(False, ColumnType.BOOLEAN)
+
     def constant(self, tree):
         for child in tree.children:
             if isinstance(child, Tree):