Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create Table fails when projecting column from native table #1007

Merged
merged 11 commits into from
Aug 31, 2023
Merged

fix: create Table fails when projecting column from native table #1007

merged 11 commits into from
Aug 31, 2023

Conversation

gaurav274
Copy link
Member

@gaurav274 gaurav274 commented Aug 30, 2023 •
edited
Loading

  1. Database handler get_columns also returns the column datatypes
  2. Throw Import errors instead of auto-installing missing dependencies.

@gaurav274 gaurav274 added the Bug 🐞 EVA is not working as expected label Aug 30, 2023
@gaurav274 gaurav274 added this to the v0.3.3 milestone Aug 30, 2023
@gaurav274 gaurav274 self-assigned this Aug 30, 2023
@gaurav274 gaurav274 linked an issue Aug 30, 2023 that may be closed by this pull request
Create Table fails when projecting column from native table #994
Closed
2 tasks
xzdandy
xzdandy reviewed Aug 31, 2023
View reviewed changes
evadb/third_party/databases/interface.py Outdated
mod = dynamic_import(engine)
except ImportError:
req_file = os.path.join(
"evadb", "third_party", "databases", engine, "requirements.txt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this path accessible if user directly installs from pip instead of source?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I realize this path will only work for dev testing. We should switch using absolute path. In addition, we also need to package requirements.txt.

Reference to my closed PR: https://github.com/georgia-tech-db/evadb/pull/1001/files

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add a new property function to the handler that returns the list of package. No need to worry about path .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't be able to import the class to access the property function.

@xzdandy xzdandy mentioned this pull request Aug 31, 2023
Merged
@gaurav274 gaurav274 merged commit fd63af1 into staging Aug 31, 2023
4 checks passed
@gaurav274 gaurav274 deleted the issue-994 branch August 31, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@jiashenC jiashenC Awaiting requested review from jiashenC

Assignees

@gaurav274 gaurav274

Labels
Bug 🐞 EVA is not working as expected
Projects
EVA Public Roadmap ⚡🚀
Archived in project
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.

Create Table fails when projecting column from native table
3 participants
@gaurav274 @xzdandy @jiashenC