Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix column name related issue for Forecast functions #1084

Merged
merged 10 commits into from
Sep 10, 2023
Merged

Fix column name related issue for Forecast functions #1084

merged 10 commits into from
Sep 10, 2023

Conversation

xzdandy
Copy link
Collaborator

@xzdandy xzdandy commented Sep 9, 2023 •
edited
Loading

Addressing item3 in #1081

  • In evadb/executor/create_function_executor.py, we rename the input relationship to a fixed schema requested by statsforecast
  • Rename the output column so it is synced with binder. A temporal fix. We will reconsider the design in UDF modularization  #1017
  • Update testcases to test the column rename feature.

@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 9, 2023
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 9, 2023
@xzdandy xzdandy self-assigned this Sep 9, 2023
@xzdandy xzdandy marked this pull request as ready for review September 9, 2023 18:35
@xzdandy
Copy link
Collaborator Author

xzdandy commented Sep 9, 2023

@americast I am not able to request your review. Please take a look.

americast
americast approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@americast americast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work great @xzdandy. Thanks!

@xzdandy xzdandy merged commit 2671059 into staging Sep 10, 2023
1 of 5 checks passed
@xzdandy xzdandy deleted the fix_uppercase_column branch September 10, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiashenC jiashenC jiashenC approved these changes

@americast americast americast approved these changes

@gaurav274 gaurav274 Awaiting requested review from gaurav274

Assignees

@xzdandy xzdandy

Labels
Bug 🐞 EVA is not working as expected
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xzdandy @jiashenC @americast