Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: df merging issues when multiple predicates #1088

Merged
merged 2 commits into from
Sep 10, 2023
Merged

fix: df merging issues when multiple predicates #1088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
681a5de
fix indices
jiashenC Sep 10, 2023
6ab041f
fix reset_index() returns nonw
jiashenC Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion evadb/expression/logical_expression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,12 @@ def evaluate(self, batch, **kwargs):
return left_batch
mask = left_batch.create_inverted_mask()

right_batch = self.get_child(1).evaluate(batch[mask], **kwargs)
# When some rows are filtered, the push down batch indices need to
# be reset as well.
pushdown_batch = batch[mask]
pushdown_batch.reset_index()

right_batch = self.get_child(1).evaluate(pushdown_batch, **kwargs)
left_batch.update_indices(mask, right_batch)

return left_batch
Expand Down