Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve db integration #1114

Merged
merged 6 commits into from
Sep 14, 2023
Merged

feat: Improve db integration #1114

merged 6 commits into from
Sep 14, 2023

Conversation

gaurav274
Copy link
Member

@gaurav274 gaurav274 commented Sep 13, 2023 •
edited
Loading

  1. Moved get_database_handler to context_manager
  2. NativeStorageEngine is now consistent with SQLStorageEngine.

@gaurav274
fix: evadb is now consistent with lowercase (#1091)
b8ebd09 
1. Converting to lowercase for the time being. Changing the binder to
take care of case sensitive databases is a long commitment and we can
revisit it later.
@gaurav274
added test case
6c7c588
@gaurav274
revert changes
21d6d2c
@gaurav274
merge staging
b7ec235
@gaurav274
fix linter
ac42dd2
@gaurav274 gaurav274 marked this pull request as ready for review September 13, 2023 23:52
@gaurav274 gaurav274 merged commit 2662ca1 into staging Sep 14, 2023
5 checks passed
@gaurav274 gaurav274 deleted the improve-db-integration branch September 14, 2023 00:47
@xzdandy xzdandy mentioned this pull request Sep 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@jiashenC jiashenC jiashenC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gaurav274 @xzdandy @jiashenC