Configuration Manager Redesign #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: evadb/catalog/catalog_manager.py new file: evadb/catalog/models/configuration_catelog.py modified: evadb/catalog/models/utils.py new file: evadb/catalog/services/configuration_catalog_service.py modified: evadb/catalog/sql_config.py Adding EvaDB base configs to a python dict new file: evadb/eva_config.py
modified: evadb/configuration/bootstrap_environment.py modified: evadb/configuration/configuration_manager.py modified: evadb/configuration/constants.py renamed: evadb/eva_config.py -> evadb/evadb_config.py
…guration_redesign
gaurav274
changed the title
hershd23
reviewed
Oct 10, 2023
|
I fixed the merge conflict. Please check if I do it in the right way. |
xzdandy
reviewed
Oct 11, 2023
evadb/binder/statement_binder.py
Outdated
| ) | ||
| # we also handle the special case of ChatGPT where we need to send the | ||
| # OpenAPI key as part of the parameter | ||
| # ToDO: this should be better handled |
There was a problem hiding this comment.
Do you think have a CREATE call like the following is the right approach?
CREATE FUNCTION myllm
TYPE llm
MODEL GPT4
OPENAI key;
If so, we can mention in the TODO comment.
There was a problem hiding this comment.
This should already work. Will handle it.
xzdandy
reviewed
Oct 11, 2023
xzdandy
reviewed
Oct 11, 2023
| config_obj = merge_dict_of_dicts(config_default_dict, config_obj) | ||
| mode = config_obj["core"]["mode"] | ||
| mode = config_obj["mode"] |
There was a problem hiding this comment.
This is not useful. We can only change the mode using SET after already bootstrapping the environment.
xzdandy
reviewed
Oct 11, 2023
xzdandy
reviewed
Oct 11, 2023
xzdandy
reviewed
Oct 11, 2023
xzdandy
reviewed
Oct 11, 2023
xzdandy
added
User Experience
High Effort 🏋
5 tasks
2 tasks
xzdandy
reviewed
Oct 11, 2023
2 tasks
gaurav274
changed the title
xzdandy
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.ymlfile. Users can directly useSETcommand.OPENAI_KEYtoOPENAI_API_KEY