Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve testcase #1294

Merged
merged 4 commits into from
Oct 17, 2023
Merged

fix: improve testcase #1294

merged 4 commits into from
Oct 17, 2023

Conversation

gaurav274
Copy link
Member

  1. Test default values of chunk_size and chunk_overlap

@gaurav274 gaurav274 self-assigned this Oct 17, 2023
@gaurav274 gaurav274 added the Minor 💅 Polishing EVA is always nice label Oct 17, 2023
xzdandy
xzdandy approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for all default values. It is better to define in the constant.py so we have a centralized place for them.

@gaurav274
Copy link
Member Author

I think for all default values. It is better to define in the constant.py so we have a centralized place for them.

Looks like I made a mistake. The default values are something else. Will fix it!

@gaurav274 gaurav274 merged commit b114304 into staging Oct 17, 2023
7 checks passed
@gaurav274 gaurav274 deleted the improve-testcases branch October 17, 2023 21:15
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Oct 30, 2023
@gaurav274 @a0x8o
fix: improve testcase (georgia-tech-db#1294)
f9e9f8b 
Test default values of `chunk_size` and `chunk_overlap`
a0x8o pushed a commit to alexxx-db/eva that referenced this pull request Nov 22, 2023
@gaurav274 @a0x8o
fix: improve testcase (georgia-tech-db#1294)
6477eba 
Test default values of `chunk_size` and `chunk_overlap`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

Assignees

@gaurav274 gaurav274

Labels
Minor 💅 Polishing EVA is always nice
Projects
EVA Public Roadmap ⚡🚀
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaurav274 @xzdandy