Replace Json with Pickle Serialization #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzdandy
approved these changes
Nov 4, 2022
| } | ||
| return json.dumps(obj, cls=BatchEncoder) | ||
| def serialize(self): | ||
| obj = {"frames": self._frames, "batch_size": len(self)} |
There was a problem hiding this comment.
What is the usage for batch_size? Can we return PickleSerializer.serialize(self)?
There was a problem hiding this comment.
For cases where we omit some rows, at least batch_size tells the row count
eva/server/networking_utils.py
Outdated
| @@ -79,3 +81,10 @@ def set_socket_io_timeouts(transport, seconds, useconds=0): | |||
| return True | |||
| except OSError: | |||
| return False | |||
|
|
|||
|
|
|||
| def serialize_message(message: str): | |||
There was a problem hiding this comment.
Shall we use typing.Any for the type hint of message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
display.pprint_nest_depthof ndarray objects in batch