Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Moved to a lark-based parser #492

Merged
merged 107 commits into from
Dec 30, 2022
Merged

feat: Moved to a lark-based parser #492

merged 107 commits into from
Dec 30, 2022

Conversation

jarulraj
Copy link
Member

@jarulraj jarulraj commented Nov 17, 2022

  • Moved from ANTLR to Lark to remove the Java dependency for simplifying developer experience
  • Added versioning for READ-THE-DOCS
  • Added ParserStatementTest to test the Statement functions (e.g., hash, eq, str)
  • Removed ParserVisitor Test as we no longer use ANTLR.

To be fixed:

  • YOLO model is intermittently buggy on CI
  • Support for exception checking in Parser
  • Fix complex parsing logic for union all statement

eva/expression/comparison_expression.py Outdated Show resolved Hide resolved
eva/expression/tuple_value_expression.py Outdated Show resolved Hide resolved
eva/parser/create_mat_view_statement.py Outdated Show resolved Hide resolved
eva/parser/eva.lark Show resolved Hide resolved
eva/parser/lark_parser.py Show resolved Hide resolved
eva/parser/lark_parser.py Outdated Show resolved Hide resolved
eva/parser/lark_parser.py Show resolved Hide resolved
eva/parser/lark_visitor/_table_sources.py Show resolved Hide resolved
tutorials/01-mnist.ipynb Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

gaurav274 commented on 2022-12-28T01:51:38Z
----------------------------------------------------------------

Line #1.    cursor.execute('DROP TABLE ObjectDetectionVideos')

Not related to the PR but we should change it to DROP TABLE IF EXISTS.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

gaurav274 commented on 2022-12-28T01:51:39Z
----------------------------------------------------------------

What happended here?


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

gaurav274 commented on 2022-12-28T01:51:39Z
----------------------------------------------------------------

Detection are worng.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

gaurav274 commented on 2022-12-28T01:51:41Z
----------------------------------------------------------------

Some issue here. Frame 10 had 2 detections earlier.


@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

gaurav274 commented on 2022-12-28T01:51:42Z
----------------------------------------------------------------

Strange, why are the results different? This is bad for reuse. @xzdandy jarulraj 


@jarulraj jarulraj merged commit 2ec9ddd into master Dec 30, 2022
@jarulraj jarulraj deleted the lark branch December 30, 2022 21:33
@jarulraj jarulraj mentioned this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants