refactor: catalog improved file and function names #544
Conversation
gaurav274
changed the title
gaurav274
changed the title
|
The original names were confusing. We were using dataset/metadata/table interchangeably. |
| @@ -20,16 +20,16 @@ | |||
| from eva.catalog.models.base_model import BaseModel | |||
|
|
|||
|
|
|||
| class DataFrameMetadata(BaseModel): | |||
| __tablename__ = "df_metadata" | |||
| class TableCatalog(BaseModel): | |||
There was a problem hiding this comment.
Just a curious comment about model in general. Why do we add a catalog suffix for all models?
To me, catalog includes everything (udf, index, etc). Would this naming give a wrong impression that we maintain different catalogs for different models? (Again, just curious, don’t need a fix).
There was a problem hiding this comment.
I referred Postgres. They also call each model as different catalog. https://www.postgresql.org/docs/current/catalog-pg-class.html.
What do you think? Maybe I'm wrong.
There was a problem hiding this comment.
I see. It seems like they use something like pg_{...} as their naming convention? I didn't really see they use catalog as suffix.
No description provided.