feat: allow UDF's to be created with any name (irrespective of class name) #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryatejreddy
changed the title
gaurav274
approved these changes
Mar 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Inspired from work on decorators coming in another PR.
Current Behavior
We currently enforce that the UDF be named same as the class in the impl file. This seems like an unnecessary restriction.
Modification
This PR introduces the following way of loading the UDF:
- If the file has a single class load that.
- Else, raise an error asking user to specify the class name as UDF in case of multiple classes in file.
Testing
Added test cases.