fix: use the same interface #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jiashenC
commented
Aug 29, 2023
jiashenC
commented
- Add some missing qdrant marker and check actual existence of qdrant.
- In-sync with interface.
xzdandy
reviewed
Aug 29, 2023
| batch_list = list(output) | ||
| return Batch.concat(batch_list, copy=False) | ||
|
|
||
|
|
||
| def execute_query( |
There was a problem hiding this comment.
What is the difference between execute_query, execute_query_fetch_all and execute_statement now? It seems that they all do the same thing. I think originally execute_query is returning a generator, which intends to be used to implement fetch_all, fetch_one, though we never implemented fetch_one.
There was a problem hiding this comment.
Surpassing this comment as this is breaking the build, and we need to hot fix it.
There was a problem hiding this comment.
Not sure the original design intension. execute_statement takes a statement as its argument so I just converted to an inner function of execute_query.
gaurav274
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.