Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Clean up the properties in the foreshadow class #156

Open
jzhang-gp opened this issue Sep 12, 2019 · 0 comments
Open

Clean up the properties in the foreshadow class #156

jzhang-gp opened this issue Sep 12, 2019 · 0 comments

Comments

@jzhang-gp
Copy link
Contributor

This might be the best time to clean up the properties that were used. I don't think the properties is the best way of auto initializing those attributes and think they should all be moved to the init, similar to what you just proposed :)

Originally posted by @cchoquette in #154
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jzhang-gp